Skip to content

Conversation

@yaotongms
Copy link
Member

Contributing to the Azure SDK

Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.

For specific information about pull request etiquette and best practices, see this section.

@github-actions github-actions bot added the Mgmt This issue is related to a management package. label Oct 23, 2024
@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

Azure.ResourceManager.HybridCompute

Copy link
Member

@archerzz archerzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yaotongms Need to update API signature. See the error logs for details. Thanks.

@yaotongms yaotongms requested a review from a team as a code owner November 18, 2024 04:44
@jsquire jsquire dismissed their stale review November 18, 2024 21:33

Core changes have been reverted.

Copy link
Member

@archerzz archerzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still some generic names to fix, Others look good to me.

If you are going to release a new version, don't forget to update CHANGELOG.md. See here for details.

@archerzz archerzz merged commit ea16541 into Azure:main Dec 2, 2024
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Mgmt This issue is related to a management package.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants