-
Notifications
You must be signed in to change notification settings - Fork 5.1k
Release preview version 2024-07-31 of HybridCompute #46789
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
archerzz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yaotongms Need to update API signature. See the error logs for details. Thanks.
sdk/hybridcompute/Azure.ResourceManager.HybridCompute/src/Generated/GatewayData.cs
Outdated
Show resolved
Hide resolved
sdk/hybridcompute/Azure.ResourceManager.HybridCompute/src/Generated/GatewayData.cs
Outdated
Show resolved
Hide resolved
sdk/hybridcompute/Azure.ResourceManager.HybridCompute/src/Generated/Models/Disk.cs
Outdated
Show resolved
Hide resolved
sdk/hybridcompute/Azure.ResourceManager.HybridCompute/src/Generated/Models/Disk.cs
Show resolved
Hide resolved
sdk/hybridcompute/Azure.ResourceManager.HybridCompute/src/Generated/Models/HardwareProfile.cs
Outdated
Show resolved
Hide resolved
...te/Azure.ResourceManager.HybridCompute/src/Generated/Models/HybridComputeNetworkInterface.cs
Show resolved
Hide resolved
sdk/hybridcompute/Azure.ResourceManager.HybridCompute/src/Generated/Models/Processor.cs
Outdated
Show resolved
Hide resolved
...ompute/Azure.ResourceManager.HybridCompute/src/Generated/Models/RunCommandManagedIdentity.cs
Outdated
Show resolved
Hide resolved
sdk/hybridcompute/Azure.ResourceManager.HybridCompute/src/Generated/Models/Settings.cs
Outdated
Show resolved
Hide resolved
...amework/tests/SessionRecords/RecordedTestBaseTests/WaitForCompletionErrorsArePropagated.json
Outdated
Show resolved
Hide resolved
archerzz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still some generic names to fix, Others look good to me.
If you are going to release a new version, don't forget to update CHANGELOG.md. See here for details.
Contributing to the Azure SDK
Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.
For specific information about pull request etiquette and best practices, see this section.